From 1599c34c358994e61bf45ba65d98a4753aaa01e3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=98yvind=20Kol=C3=A5s?= Date: Tue, 9 Aug 2005 20:52:59 +0000 Subject: [PATCH] improve error reporting --- ChangeLog | 8 ++++++++ babl/babl-classes.c | 2 +- babl/babl-format.c | 1 + babl/babl-internal.c | 2 +- babl/babl-internal.h | 10 +++++++++- babl/babl-pixel-format.c | 1 + 6 files changed, 21 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index f8e2630..65f8c08 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2005-08-09 Øyvind Kolås + + * babl/babl-internal.h: issue a babl_log when the named object is not + found durin string based lookup. + * babl/babl-pixel-format.c: added BABL_IMAGE to var_args switch. + * babl/babl-classes.c: set babl_hmpf_on_name_lookups initial value to + 0, to make it hmpf only in babl-base. + 2005-08-09 Øyvind Kolås * babl/Makefile-mini: added babl-image.o. diff --git a/babl/babl-classes.c b/babl/babl-classes.c index 6303c9f..f39350a 100644 --- a/babl/babl-classes.c +++ b/babl/babl-classes.c @@ -43,5 +43,5 @@ babl_class_name (BablClassType klass) return class_names[klass-BABL_INSTANCE]; } -int babl_hmpf_on_name_lookups = 1; +int babl_hmpf_on_name_lookups = 0; diff --git a/babl/babl-format.c b/babl/babl-format.c index 3f9c254..226125c 100644 --- a/babl/babl-format.c +++ b/babl/babl-format.c @@ -146,6 +146,7 @@ babl_pixel_format_new (const char *name, case BABL_CONVERSION_PIXEL_FORMAT: case BABL_CONVERSION_PIXEL_FORMAT_PLANAR: case BABL_FISH: + case BABL_IMAGE: babl_log ("%s(): %s unexpected", __FUNCTION__, babl_class_name (babl->instance.type)); break; diff --git a/babl/babl-internal.c b/babl/babl-internal.c index 6303c9f..f39350a 100644 --- a/babl/babl-internal.c +++ b/babl/babl-internal.c @@ -43,5 +43,5 @@ babl_class_name (BablClassType klass) return class_names[klass-BABL_INSTANCE]; } -int babl_hmpf_on_name_lookups = 1; +int babl_hmpf_on_name_lookups = 0; diff --git a/babl/babl-internal.h b/babl/babl-internal.h index fffa022..ea85b82 100644 --- a/babl/babl-internal.h +++ b/babl/babl-internal.h @@ -57,11 +57,19 @@ type_name##_id (int id) \ TypeName * \ type_name (const char *name) \ { \ + TypeName *ret; \ + \ if (babl_hmpf_on_name_lookups) \ { \ babl_log ("%s(\"%s\"): hmpf!", __FUNCTION__, name); \ } \ - return (TypeName*) db_exist (0, name); \ + ret = (TypeName*) db_exist (0, name); \ + \ + if (!ret) \ + { \ + babl_log ("%s(\"%s\"): not found", __FUNCTION__, name); \ + } \ + return ret; \ } #define BABL_DEFINE_INIT(type_name) \ diff --git a/babl/babl-pixel-format.c b/babl/babl-pixel-format.c index 3f9c254..226125c 100644 --- a/babl/babl-pixel-format.c +++ b/babl/babl-pixel-format.c @@ -146,6 +146,7 @@ babl_pixel_format_new (const char *name, case BABL_CONVERSION_PIXEL_FORMAT: case BABL_CONVERSION_PIXEL_FORMAT_PLANAR: case BABL_FISH: + case BABL_IMAGE: babl_log ("%s(): %s unexpected", __FUNCTION__, babl_class_name (babl->instance.type)); break; -- 2.30.2